test(react19-tests-v9): run integration tests type-check against source #34864

dmytrokirpa · 2025-07-17T21:14:24Z

Previous Behavior

React 19 type-check:integartion task were run against components stories only

New Behavior

React 19 type-check:integartion task is using both stories and packages source.

Fixed type issues:

RefObject no longer makes current nullable by default https://github.com/eps1lon/types-react-codemod?tab=readme-ov-file#refobject-defaults-react-19
useRef now always requires an initial value. Implicit undefined is forbidden. https://github.com/eps1lon/types-react-codemod?tab=readme-ov-file#useref-required-initial-react-19
added the JSX export https://github.com/microsoft/fluentui/pull/34864/files#diff-428c59ef5111466eacfd109eade5a36ca2550467e16bad73cbd8b75494a54cc6R3 to Fluent's custom JSX runtime, to make it work with React 19.

Related Issue(s)

Implements run type-check integration against source files to mitigate "unexpected surprises" when migrating repo to R19 / D #34927
Partially implements [Feature]: add react 19 support to react-components #34768
~~Blocked by chore: fix react 19 integration tests type issues for v9 #34722~~

github-actions · 2025-07-17T21:16:50Z

📊 Bundle size report

Package & Exports	Baseline (minified/GZIP)	PR	Change
`react-accordion` Accordion (including children components)	`108.433 kB` `33.152 kB`	`108.444 kB` `33.159 kB`	`11 B` `7 B`
`react-calendar-compat` Calendar Compat	`149.77 kB` `39.934 kB`	`149.782 kB` `39.934 kB`	`12 B`
`react-card` Card - All	`106.022 kB` `29.795 kB`	`106.044 kB` `29.799 kB`	`22 B` `4 B`
`react-card` Card	`98.668 kB` `27.92 kB`	`98.69 kB` `27.924 kB`	`22 B` `4 B`
`react-charts` AreaChart	`384.093 kB` `117.078 kB`	`384.134 kB` `117.09 kB`	`41 B` `12 B`
`react-charts` DeclarativeChart	`679.2 kB` `194.736 kB`	`679.241 kB` `194.75 kB`	`41 B` `14 B`
`react-charts` DonutChart	`295.497 kB` `88.282 kB`	`295.538 kB` `88.297 kB`	`41 B` `15 B`
`react-charts` FunnelChart	`287.632 kB` `85.523 kB`	`287.673 kB` `85.539 kB`	`41 B` `16 B`
`react-charts` GanttChart	`367.402 kB` `110.592 kB`	`367.443 kB` `110.605 kB`	`41 B` `13 B`
`react-charts` GaugeChart	`310.669 kB` `92.027 kB`	`310.71 kB` `92.04 kB`	`41 B` `13 B`
`react-charts` GroupedVerticalBarChart	`370.819 kB` `111.657 kB`	`370.86 kB` `111.671 kB`	`41 B` `14 B`
`react-charts` HeatMapChart	`369.32 kB` `112.179 kB`	`369.361 kB` `112.199 kB`	`41 B` `20 B`
`react-charts` HorizontalBarChart	`295.165 kB` `86.841 kB`	`295.206 kB` `86.857 kB`	`41 B` `16 B`
`react-charts` Legends	`234.804 kB` `69.464 kB`	`234.845 kB` `69.479 kB`	`41 B` `15 B`
`react-charts` LineChart	`393.487 kB` `118.608 kB`	`393.528 kB` `118.622 kB`	`41 B` `14 B`
`react-charts` SankeyChart	`198.708 kB` `61.031 kB`	`198.73 kB` `61.034 kB`	`22 B` `3 B`
`react-charts` ScatterChart	`375.161 kB` `113.141 kB`	`375.202 kB` `113.155 kB`	`41 B` `14 B`
`react-charts` VerticalBarChart	`409.969 kB` `118.693 kB`	`410.01 kB` `118.705 kB`	`41 B` `12 B`
`react-charts` VerticalStackedBarChart	`381.711 kB` `114.569 kB`	`381.752 kB` `114.585 kB`	`41 B` `16 B`
`react-components` react-components: Button, FluentProvider & webLightTheme	`68.79 kB` `19.902 kB`	`68.796 kB` `19.903 kB`	`6 B` `1 B`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`236.575 kB` `68.497 kB`	`236.614 kB` `68.509 kB`	`39 B` `12 B`
`react-components` react-components: FluentProvider & webLightTheme	`43.624 kB` `14.255 kB`	`43.63 kB` `14.257 kB`	`6 B` `2 B`
`react-components` react-components: entire library	`1.282 MB` `322.799 kB`	`1.282 MB` `322.818 kB`	`109 B` `19 B`
`react-datepicker-compat` DatePicker Compat	`226.641 kB` `64.089 kB`	`226.653 kB` `64.089 kB`	`12 B`
`react-dialog` Dialog (including children components)	`102.486 kB` `30.64 kB`	`102.514 kB` `30.642 kB`	`28 B` `2 B`
`react-list` List	`88.9 kB` `26.384 kB`	`88.922 kB` `26.387 kB`	`22 B` `3 B`
`react-menu` Menu (including children components)	`165.093 kB` `49.993 kB`	`165.115 kB` `49.994 kB`	`22 B` `1 B`
`react-menu` Menu (including selectable components)	`168.075 kB` `50.587 kB`	`168.097 kB` `50.588 kB`	`22 B` `1 B`
`react-motion` @fluentui/react-motion - createMotionComponent()	`4.019 kB` `1.761 kB`	`4.025 kB` `1.763 kB`	`6 B` `2 B`
`react-motion` @fluentui/react-motion - createPresenceComponent()	`5.674 kB` `2.368 kB`	`5.68 kB` `2.37 kB`	`6 B` `2 B`
`react-popover` Popover	`132.278 kB` `41.174 kB`	`132.3 kB` `41.178 kB`	`22 B` `4 B`
`react-provider` FluentProvider	`23.8 kB` `8.556 kB`	`23.806 kB` `8.557 kB`	`6 B` `1 B`
`react-table` DataGrid	`161.033 kB` `45.54 kB`	`161.061 kB` `45.539 kB`	`28 B` `-1 B`
`react-tag-picker` @fluentui/react-tag-picker - package	`188.302 kB` `56.455 kB`	`188.33 kB` `56.457 kB`	`28 B` `2 B`
`react-tags` TagGroup	`83.097 kB` `24.559 kB`	`83.125 kB` `24.561 kB`	`28 B` `2 B`
`react-teaching-popover` TeachingPopover	`102.755 kB` `30.736 kB`	`102.777 kB` `30.738 kB`	`22 B` `2 B`
`react-toast` Toast (including Toaster)	`103.544 kB` `30.999 kB`	`103.572 kB` `31.008 kB`	`28 B` `9 B`
`react-tree` FlatTree	`149.198 kB` `42.681 kB`	`149.232 kB` `42.682 kB`	`34 B` `1 B`
`react-tree` PersonaFlatTree	`149.954 kB` `42.811 kB`	`149.988 kB` `42.815 kB`	`34 B` `4 B`
`react-tree` PersonaTree	`146.211 kB` `41.667 kB`	`146.247 kB` `41.668 kB`	`36 B` `1 B`
`react-tree` Tree	`145.461 kB` `41.529 kB`	`145.495 kB` `41.533 kB`	`34 B` `4 B`

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `328 B`
`global-context` createContextSelector	`537 B` `339 B`
`react-aria` ARIA - Default	`237 B` `181 B`
`react-avatar` Avatar	`48.518 kB` `15.508 kB`
`react-avatar` AvatarGroup	`19.235 kB` `7.617 kB`
`react-avatar` AvatarGroupItem	`62.662 kB` `19.727 kB`
`react-badge` Badge	`25.06 kB` `8.242 kB`
`react-badge` CounterBadge	`25.84 kB` `8.517 kB`
`react-badge` PresenceBadge	`24.929 kB` `9.147 kB`
`react-breadcrumb` @fluentui/react-breadcrumb - package	`114.22 kB` `31.522 kB`
`react-button` Button	`36.705 kB` `10.508 kB`
`react-button` CompoundButton	`43.117 kB` `11.812 kB`
`react-button` MenuButton	`41.6 kB` `11.902 kB`
`react-button` SplitButton	`49.667 kB` `13.477 kB`
`react-button` ToggleButton	`52.636 kB` `12.285 kB`
`react-card` CardFooter	`13.662 kB` `5.517 kB`
`react-card` CardHeader	`16.195 kB` `6.38 kB`
`react-card` CardPreview	`13.729 kB` `5.645 kB`
`react-charts` HorizontalBarChartWithAxis	`63 B` `83 B`
`react-charts` Sparkline	`91.123 kB` `28.692 kB`
`react-checkbox` Checkbox	`34.335 kB` `11.786 kB`
`react-color-picker` ColorArea	`49.32 kB` `17.32 kB`
`react-color-picker` ColorPicker	`17.95 kB` `7.143 kB`
`react-color-picker` ColorSlider	`41.493 kB` `15.375 kB`
`react-combobox` Combobox (including child components)	`106.952 kB` `34.798 kB`
`react-combobox` Dropdown (including child components)	`107.582 kB` `34.719 kB`
`react-divider` Divider	`20.626 kB` `7.654 kB`
`react-field` Field	`22.657 kB` `8.602 kB`
`react-image` Image	`14.489 kB` `5.882 kB`
`react-input` Input	`27.148 kB` `9.108 kB`
`react-jsx-runtime` Classic Pragma	`1.101 kB` `550 B`
`react-jsx-runtime` JSX Dev Runtime	`2.8 kB` `1.251 kB`
`react-jsx-runtime` JSX Runtime	`3.422 kB` `1.493 kB`
`react-label` Label	`13.799 kB` `5.644 kB`
`react-link` Link	`16.746 kB` `6.785 kB`
`react-list` ListItem	`112.284 kB` `33.207 kB`
`react-message-bar` MessageBar (all components)	`24.088 kB` `8.96 kB`
`react-motion` @fluentui/react-motion - PresenceGroup	`1.727 kB` `823 B`
`react-overflow` hooks only	`12.854 kB` `4.828 kB`
`react-persona` Persona	`55.409 kB` `17.389 kB`
`react-portal` Portal	`15.411 kB` `5.385 kB`
`react-portal-compat` PortalCompatProvider	`8.386 kB` `2.624 kB`
`react-positioning` usePositioning	`28.865 kB` `10.146 kB`
`react-positioning` useSafeZoneArea	`12.29 kB` `4.967 kB`
`react-progress` ProgressBar	`16.593 kB` `6.613 kB`
`react-radio` Radio	`31.8 kB` `10.006 kB`
`react-radio` RadioGroup	`14.889 kB` `6.09 kB`
`react-select` Select	`26.95 kB` `9.833 kB`
`react-slider` Slider	`37.211 kB` `12.461 kB`
`react-spinbutton` SpinButton	`34.431 kB` `11.449 kB`
`react-spinner` Spinner	`24.396 kB` `8.201 kB`
`react-swatch-picker` @fluentui/react-swatch-picker - package	`106.047 kB` `30.539 kB`
`react-switch` Switch	`34.51 kB` `11.014 kB`
`react-table` Table (Primitives only)	`41.978 kB` `13.573 kB`
`react-table` Table as DataGrid	`131.484 kB` `36.345 kB`
`react-table` Table (Selection only)	`69.846 kB` `19.704 kB`
`react-table` Table (Sort only)	`68.489 kB` `19.321 kB`
`react-tags` InteractionTag	`14.561 kB` `5.865 kB`
`react-tags` Tag	`30.379 kB` `9.779 kB`
`react-text` Text - Default	`16.19 kB` `6.366 kB`
`react-text` Text - Wrappers	`19.35 kB` `6.695 kB`
`react-textarea` Textarea	`25.53 kB` `9.361 kB`
`react-timepicker-compat` TimePicker	`109.935 kB` `36.335 kB`
`react-tooltip` Tooltip	`57.922 kB` `20.084 kB`
`react-utilities` SSRProvider	`180 B` `160 B`

_{🤖 This report was generated against 458c66f071c0c04d32cbd9f932e2146e18529eae}

github-actions · 2025-07-17T21:17:29Z

Pull request demo site: URL

dmytrokirpa · 2025-08-20T12:00:08Z

packages/react-components/react-accordion/library/src/components/Accordion/useAccordion.ts

@@ -52,7 +53,7 @@ export const useAccordion_unstable = <Value = AccordionItemValue>(
    },
    root: slot.always(
      getIntrinsicElementProps('div', {
-        ...props,
+        ...rest,


custom onToggle callback conflicts with the native HTML one

apps/react-19-tests-v9/package.json

dmytrokirpa · 2025-08-28T22:03:29Z

packages/react-components/react-infolabel/library/src/components/InfoButton/InfoButton.types.ts

@@ -18,7 +18,7 @@ export type InfoButtonSlots = {
 /**
 * InfoButton Props
 */
-export type InfoButtonProps = Omit<ComponentProps<Partial<InfoButtonSlots>>, 'disabled'> & {
+export type InfoButtonProps = Omit<ComponentProps<Partial<InfoButtonSlots>>, 'disabled' | 'popover'> & {


The popover prop clashes with the HTMLElement's popover attrbiute

packages/react-components/react-jsx-runtime/src/jsx-runtime/index.d.ts__tmpl__

apps/react-19-tests-v9/tsconfig.react-19-source.json

packages/react-components/react-motion/library/src/components/PresenceGroup.tsx

Hotell

few things need to be reverted/changed otherwise good to go

packages/react-components/react-motion/library/src/factories/createPresenceComponent.ts

packages/react-components/react-motion/library/etc/react-motion.api.md

apps/react-19-tests-v9/tsconfig.react-19-source.json

… imports

…s-ignore for React.Component constructor

dmytrokirpa · 2025-09-04T12:34:04Z

apps/react-19-tests-v9/tsconfig.react-19-source.json

@@ -3,7 +3,7 @@
    "target": "ES2019",
    "module": "esnext",
    "moduleResolution": "node",
-    "lib": ["ES2019", "dom"],
+    "lib": ["ES2019", "ES2020.Intl", "dom"],


ES2020.Intl is needed for time-picker-compat https://github.com/microsoft/fluentui/blob/master/packages/react-components/react-timepicker-compat/library/tsconfig.lib.json#L5

dmytrokirpa self-assigned this Jul 17, 2025

dmytrokirpa mentioned this pull request Jul 28, 2025

[Feature]: add react 19 support to react-components #34768

Open

15 tasks

dmytrokirpa linked an issue Jul 28, 2025 that may be closed by this pull request

[Feature]: add react 19 support to react-components #34768

Open

15 tasks

dmytrokirpa force-pushed the test/react19-tests-v9/tsc-against-source branch from bd93682 to 1c0cd52 Compare August 20, 2025 11:44

dmytrokirpa commented Aug 20, 2025

View reviewed changes

github-actions bot reviewed Aug 20, 2025

View reviewed changes

apps/react-19-tests-v9/package.json Show resolved Hide resolved

dmytrokirpa force-pushed the test/react19-tests-v9/tsc-against-source branch from e20be29 to 7494b8f Compare August 28, 2025 21:58

dmytrokirpa commented Aug 28, 2025

View reviewed changes

dmytrokirpa marked this pull request as ready for review September 1, 2025 07:55

dmytrokirpa requested review from a team, Mitch-At-Work, mainframev, ValentinaKozlova and marcosmoura as code owners September 1, 2025 07:55

dmytrokirpa commented Sep 1, 2025

View reviewed changes

packages/react-components/react-jsx-runtime/src/jsx-runtime/index.d.ts__tmpl__ Outdated Show resolved Hide resolved

dmytrokirpa requested a review from Hotell September 1, 2025 07:57

dmytrokirpa added Fluent UI react-components (v9) React 19 labels Sep 1, 2025

Hotell reviewed Sep 2, 2025

View reviewed changes

apps/react-19-tests-v9/tsconfig.react-19-source.json Outdated Show resolved Hide resolved

Hotell reviewed Sep 2, 2025

View reviewed changes

packages/react-components/react-motion/library/src/components/PresenceGroup.tsx Outdated Show resolved Hide resolved

Hotell reviewed Sep 2, 2025

View reviewed changes

packages/react-components/react-motion/library/src/factories/createPresenceComponent.ts Outdated Show resolved Hide resolved

packages/react-components/react-motion/library/etc/react-motion.api.md Show resolved Hide resolved

ValentinaKozlova approved these changes Sep 2, 2025

View reviewed changes

dmytrokirpa force-pushed the test/react19-tests-v9/tsc-against-source branch from 8b44316 to f007f24 Compare September 2, 2025 16:35

dmytrokirpa requested a review from Hotell September 3, 2025 14:51

Hotell reviewed Sep 4, 2025

View reviewed changes

apps/react-19-tests-v9/tsconfig.react-19-source.json Outdated Show resolved Hide resolved

Hotell approved these changes Sep 4, 2025

View reviewed changes

dmytrokirpa added 16 commits September 4, 2025 11:42

test(react19-tests-v9): run integration tests type-check against source

d317802

fix type-issues

2d3cc1e

change

6914ca0

fix react 19 jsx

4b5b0f8

fix react 19 type issues with infolabel

e14c724

change files

40a9a5b

revert change

2bd7793

change

2de27f0

use correct react/jsx-runtime version for integration tests

56daec7

revert unnecessary. change

e52c37e

update api snapshot

38fbfcb

fix issues after rebase

c7c5b07

fixup

98911bd

review feedback

ebefbc5

refactor: update import statements to use 'import type' for type-only…

7b060db

… imports

update type definitions used for integration testing

40cc9c2

dmytrokirpa force-pushed the test/react19-tests-v9/tsc-against-source branch 2 times, most recently from fbe712e to 40cc9c2 Compare September 4, 2025 09:50

dmytrokirpa added 2 commits September 4, 2025 12:43

fix: update TypeScript configuration to include ES2020.Intl and add t…

5abdde1

…s-ignore for React.Component constructor

fix eslint error

5058bc1

dmytrokirpa commented Sep 4, 2025

View reviewed changes

Hotell merged commit cf1eb5f into microsoft:master Sep 4, 2025
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(react19-tests-v9): run integration tests type-check against source #34864

test(react19-tests-v9): run integration tests type-check against source #34864

dmytrokirpa commented Jul 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

dmytrokirpa Aug 20, 2025

Uh oh!

Uh oh!

dmytrokirpa Aug 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hotell left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmytrokirpa Sep 4, 2025

Uh oh!

Uh oh!

Uh oh!

test(react19-tests-v9): run integration tests type-check against source #34864

test(react19-tests-v9): run integration tests type-check against source #34864

Conversation

dmytrokirpa commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

Related Issue(s)

Uh oh!

github-actions bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

dmytrokirpa Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dmytrokirpa Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hotell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmytrokirpa Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dmytrokirpa commented Jul 17, 2025 •

edited

Loading

github-actions bot commented Jul 17, 2025 •

edited

Loading